I lke both Red Rock and Valley of Fire. Personally, I have always liked Red Rock there is just something about being there that is so peaceful. I find that going there takes some of the hustle bustle of vacation and gives it a breather.
Both are great, but I actually vote for Valley of Fire. The drive is fun, and the park is absolutely stunning. I have been to Red Rock so many times though, so that may be my reason for recommending VOF over Red Rock. Either way both are sure winners.
In the summer, Red Rock. The rocks at Valley of Fire are way too hot to do any climbing in the summer. In cool weather, I'd go with the Valley. You can easily do the Canyon in an afternoon. The Valley is more of an all day adventure.